fix(mfa): Make MfaRequiredError extend AccessTokenError and privatize encrypt_mfa_token#104
Merged
kishore7snehil merged 1 commit intomainfrom Apr 24, 2026
Merged
Conversation
… encrypt_mfa_token MfaRequiredError now extends AccessTokenError so existing except AccessTokenError handlers in get_access_token() callers continue to work. Callers needing MFA-specific handling can catch MfaRequiredError before AccessTokenError. Renamed encrypt_mfa_token to _encrypt_mfa_token since it is only called internally by ServerClient.get_access_token().
nandan-bhat
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
get_access_token()could throwMfaRequiredErrorwhich would not be caught by existingexcept AccessTokenErrorhandlers, silently breaking callers that rely on that pattern. Callers needing MFA-specific handling can catchMfaRequiredErrorbeforeAccessTokenError.encrypt_mfa_tokento_encrypt_mfa_tokensince it is only called internally byServerClient.get_access_token().decrypt_mfa_tokenremains public as callers need it to unwrap tokens fromMfaRequiredError.